Adding globalization for decimal, double and single for conversion.#97
Merged
Conversation
csantero
added a commit
that referenced
this pull request
Jul 18, 2015
Adding globalization for decimal, double and single for conversion.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug for the FilteringTransformer and the Value Converter for Decimals, doubles and singles. In some cultures, such as se-SE, the decimal point is formatted as a comma (,). I don't remember which spec is says so in but I'm pretty sure that URIs and JSON wants non-localized formatting on those.
Added some regression tests that you can test out (without my changes) to see it fail.