Skip to content

use PATCH instead of PUT for updates #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csantero merged 1 commit into from
Mar 13, 2015
Merged

use PATCH instead of PUT for updates #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions JSONAPI.EntityFramework.Tests/Acceptance/AcceptanceTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ protected async Task<HttpResponseMessage> SubmitPost(DbConnection effortConnecti
}

#endregion
#region PUT
#region PATCH

protected async Task<HttpResponseMessage> SubmitPut(DbConnection effortConnection, string requestPath, string requestDataTextResourcePath)
protected async Task<HttpResponseMessage> SubmitPatch(DbConnection effortConnection, string requestPath, string requestDataTextResourcePath)
{
using (var server = TestServer.Create(app =>
{
Expand All @@ -102,7 +102,7 @@ protected async Task<HttpResponseMessage> SubmitPut(DbConnection effortConnectio
.And(request =>
{
request.Content = new StringContent(requestContent, Encoding.UTF8, "application/vnd.api+json");
}).SendAsync("PUT");
}).SendAsync("PATCH");
return response;
}
}
Expand Down
0 ...PutWithArrayRelationshipValueRequest.json → ...tchWithArrayRelationshipValueRequest.json
View file
Open in desktop
File renamed without changes.
0 ...quests/PutWithAttributeUpdateRequest.json → ...ests/PatchWithAttributeUpdateRequest.json
View file
Open in desktop
File renamed without changes.
0 ...uests/PutWithMissingToManyIdsRequest.json → ...sts/PatchWithMissingToManyIdsRequest.json
View file
Open in desktop
File renamed without changes.
0 ...ests/PutWithMissingToManyTypeRequest.json → ...ts/PatchWithMissingToManyTypeRequest.json
View file
Open in desktop
File renamed without changes.
0 ...equests/PutWithMissingToOneIdRequest.json → ...uests/PatchWithMissingToOneIdRequest.json
View file
Open in desktop
File renamed without changes.
0 ...uests/PutWithMissingToOneTypeRequest.json → ...sts/PatchWithMissingToOneTypeRequest.json
View file
Open in desktop
File renamed without changes.
0 ...quests/PutWithNullToOneUpdateRequest.json → ...ests/PatchWithNullToOneUpdateRequest.json
View file
Open in desktop
File renamed without changes.
0 ...utWithStringRelationshipValueRequest.json → ...chWithStringRelationshipValueRequest.json
View file
Open in desktop
File renamed without changes.
0 .../PutWithToManyEmptyDataUpdateRequest.json → ...atchWithToManyEmptyDataUpdateRequest.json
View file
Open in desktop
File renamed without changes.
0 ...thToManyHomogeneousDataUpdateRequest.json → ...thToManyHomogeneousDataUpdateRequest.json
View file
Open in desktop
File renamed without changes.
0 .../Requests/PutWithToManyUpdateRequest.json → ...equests/PatchWithToManyUpdateRequest.json
View file
Open in desktop
File renamed without changes.
0 ...s/Requests/PutWithToOneUpdateRequest.json → ...Requests/PatchWithToOneUpdateRequest.json
View file
Open in desktop
File renamed without changes.
0 ...utWithArrayRelationshipValueResponse.json → ...chWithArrayRelationshipValueResponse.json
View file
Open in desktop
File renamed without changes.
0 ...onses/PutWithAttributeUpdateResponse.json → ...ses/PatchWithAttributeUpdateResponse.json
View file
Open in desktop
File renamed without changes.
0 ...nses/PutWithMissingToManyIdsResponse.json → ...es/PatchWithMissingToManyIdsResponse.json
View file
Open in desktop
File renamed without changes.
0 ...ses/PutWithMissingToManyTypeResponse.json → ...s/PatchWithMissingToManyTypeResponse.json
View file
Open in desktop
File renamed without changes.
0 ...ponses/PutWithMissingToOneIdResponse.json → ...nses/PatchWithMissingToOneIdResponse.json
View file
Open in desktop
File renamed without changes.
0 ...nses/PutWithMissingToOneTypeResponse.json → ...es/PatchWithMissingToOneTypeResponse.json
View file
Open in desktop
File renamed without changes.
0 ...onses/PutWithNullToOneUpdateResponse.json → ...ses/PatchWithNullToOneUpdateResponse.json
View file
Open in desktop
File renamed without changes.
0 ...tWithStringRelationshipValueResponse.json → ...hWithStringRelationshipValueResponse.json
View file
Open in desktop
File renamed without changes.
0 ...PutWithToManyEmptyDataUpdateResponse.json → ...tchWithToManyEmptyDataUpdateResponse.json
View file
Open in desktop
File renamed without changes.
0 ...hToManyHomogeneousDataUpdateResponse.json → ...hToManyHomogeneousDataUpdateResponse.json
View file
Open in desktop
File renamed without changes.
0 ...esponses/PutWithToManyUpdateResponse.json → ...ponses/PatchWithToManyUpdateResponse.json
View file
Open in desktop
File renamed without changes.
0 ...Responses/PutWithToOneUpdateResponse.json → ...sponses/PatchWithToOneUpdateResponse.json
View file
Open in desktop
File renamed without changes.
72 changes: 36 additions & 36 deletions JSONAPI.EntityFramework.Tests/Acceptance/PostsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,13 @@ public async Task Post()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithAttributeUpdate()
public async Task PatchWithAttributeUpdate()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithAttributeUpdateRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithAttributeUpdateRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithAttributeUpdateResponse.json", HttpStatusCode.OK);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithAttributeUpdateResponse.json", HttpStatusCode.OK);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -123,13 +123,13 @@ public async Task PutWithAttributeUpdate()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithToManyUpdate()
public async Task PatchWithToManyUpdate()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithToManyUpdateRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithToManyUpdateRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithToManyUpdateResponse.json", HttpStatusCode.OK);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithToManyUpdateResponse.json", HttpStatusCode.OK);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -152,13 +152,13 @@ public async Task PutWithToManyUpdate()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithToManyHomogeneousDataUpdate()
public async Task PatchWithToManyHomogeneousDataUpdate()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithToManyHomogeneousDataUpdateRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithToManyHomogeneousDataUpdateRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithToManyHomogeneousDataUpdateResponse.json", HttpStatusCode.OK);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithToManyHomogeneousDataUpdateResponse.json", HttpStatusCode.OK);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -181,13 +181,13 @@ public async Task PutWithToManyHomogeneousDataUpdate()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithToManyEmptyDataUpdate()
public async Task PatchWithToManyEmptyDataUpdate()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithToManyEmptyDataUpdateRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithToManyEmptyDataUpdateRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithToManyEmptyDataUpdateResponse.json", HttpStatusCode.OK);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithToManyEmptyDataUpdateResponse.json", HttpStatusCode.OK);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -210,13 +210,13 @@ public async Task PutWithToManyEmptyDataUpdate()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithToOneUpdate()
public async Task PatchWithToOneUpdate()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithToOneUpdateRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithToOneUpdateRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithToOneUpdateResponse.json", HttpStatusCode.OK);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithToOneUpdateResponse.json", HttpStatusCode.OK);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -239,13 +239,13 @@ public async Task PutWithToOneUpdate()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithNullToOneUpdate()
public async Task PatchWithNullToOneUpdate()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithNullToOneUpdateRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithNullToOneUpdateRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithNullToOneUpdateResponse.json", HttpStatusCode.OK);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithNullToOneUpdateResponse.json", HttpStatusCode.OK);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -268,13 +268,13 @@ public async Task PutWithNullToOneUpdate()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithMissingToOneId()
public async Task PatchWithMissingToOneId()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithMissingToOneIdRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithMissingToOneIdRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithMissingToOneIdResponse.json", HttpStatusCode.BadRequest);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithMissingToOneIdResponse.json", HttpStatusCode.BadRequest);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -297,13 +297,13 @@ public async Task PutWithMissingToOneId()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithMissingToOneType()
public async Task PatchWithMissingToOneType()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithMissingToOneTypeRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithMissingToOneTypeRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithMissingToOneTypeResponse.json", HttpStatusCode.BadRequest);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithMissingToOneTypeResponse.json", HttpStatusCode.BadRequest);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -326,13 +326,13 @@ public async Task PutWithMissingToOneType()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithMissingToManyIds()
public async Task PatchWithMissingToManyIds()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithMissingToManyIdsRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithMissingToManyIdsRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithMissingToManyIdsResponse.json", HttpStatusCode.BadRequest);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithMissingToManyIdsResponse.json", HttpStatusCode.BadRequest);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -355,13 +355,13 @@ public async Task PutWithMissingToManyIds()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithMissingToManyType()
public async Task PatchWithMissingToManyType()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithMissingToManyTypeRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithMissingToManyTypeRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithMissingToManyTypeResponse.json", HttpStatusCode.BadRequest);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithMissingToManyTypeResponse.json", HttpStatusCode.BadRequest);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -384,13 +384,13 @@ public async Task PutWithMissingToManyType()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithArrayRelationshipValue()
public async Task PatchWithArrayRelationshipValue()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithArrayRelationshipValueRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithArrayRelationshipValueRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithArrayRelationshipValueResponse.json", HttpStatusCode.BadRequest);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithArrayRelationshipValueResponse.json", HttpStatusCode.BadRequest);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand All @@ -413,13 +413,13 @@ public async Task PutWithArrayRelationshipValue()
[DeploymentItem(@"Acceptance\Data\PostTagLink.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\Tag.csv", @"Acceptance\Data")]
[DeploymentItem(@"Acceptance\Data\User.csv", @"Acceptance\Data")]
public async Task PutWithStringRelationshipValue()
public async Task PatchWithStringRelationshipValue()
{
using (var effortConnection = GetEffortConnection())
{
var response = await SubmitPut(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PutWithStringRelationshipValueRequest.json");
var response = await SubmitPatch(effortConnection, "posts/202", @"Acceptance\Fixtures\Posts\Requests\PatchWithStringRelationshipValueRequest.json");

await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PutWithStringRelationshipValueResponse.json", HttpStatusCode.BadRequest);
await AssertResponseContent(response, @"Acceptance\Fixtures\Posts\Responses\PatchWithStringRelationshipValueResponse.json", HttpStatusCode.BadRequest);

using (var dbContext = new TestDbContext(effortConnection, false))
{
Expand Down
Loading