Byte Id Serialization#66
Merged
Merged
Conversation
Closed
This pull request allows to have Id of type byte. They will be serialized properly.
Collaborator
|
Looks good! Eventually we need a more generic solution that will allow for any primitive type to be used as the ID property, but this is fine for now. One small nitpick, could you reformat the braces to be in line with the brace style used elsewhere in the project? Allman-style, brace goes on the next line. Thanks |
Contributor
Author
|
I will do Allman-style in the future. I agree regarding having a more generic way of doing id serialization. Probably need something similar to the |
Collaborator
|
Thanks! @SphtKr LGTM? |
Collaborator
|
Merged and pushed to NuGet as 0.3.0-pre-2 |
Collaborator
|
Yes we should unify this function with the |
Contributor
Author
|
Thanks @SphtKr ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
This pull request allows to have Id of type byte. They will be
serialized properly.