store relationship configurations by name instead of property

Chris Santero · Chris Santero · commit e8517488f101 · 2015-07-15T18:31:17.000-04:00
It breaks for inheritance
diff --git a/JSONAPI.Autofac/JsonApiAutofacModule.cs b/JSONAPI.Autofac/JsonApiAutofacModule.cs
@@ -43,7 +43,7 @@ protected override void Load(ContainerBuilder builder)
                 {
                     IResourceTypeRelationshipConfiguration relationshipConfiguration;
                     if (resourceTypeConfiguration.RelationshipConfigurations
-                        .TryGetValue(relationship.Property, out relationshipConfiguration))
+                        .TryGetValue(relationship.Property.Name, out relationshipConfiguration))
                     {
                         if (relationshipConfiguration.MaterializerType != null)
                         {
@@ -109,7 +109,7 @@ protected override void Load(ContainerBuilder builder)
 
                     // First, see if they have set an explicit materializer for this relationship
                     IResourceTypeRelationshipConfiguration relationshipConfiguration;
-                    if (configuration.RelationshipConfigurations.TryGetValue(relationship.Property,
+                    if (configuration.RelationshipConfigurations.TryGetValue(relationship.Property.Name,
                         out relationshipConfiguration) && relationshipConfiguration.MaterializerType != null)
                         return (IRelatedResourceDocumentMaterializer)context.Resolve(relationshipConfiguration.MaterializerType, parameters);
 
diff --git a/JSONAPI/Configuration/IResourceTypeConfiguration.cs b/JSONAPI/Configuration/IResourceTypeConfiguration.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq.Expressions;
-using System.Reflection;
 using JSONAPI.Core;
 
 namespace JSONAPI.Configuration
@@ -34,7 +33,7 @@ public interface IResourceTypeConfiguration
         /// <summary>
         /// Configurations for this type's resources
         /// </summary>
-        IDictionary<PropertyInfo, IResourceTypeRelationshipConfiguration> RelationshipConfigurations { get; }
+        IDictionary<string, IResourceTypeRelationshipConfiguration> RelationshipConfigurations { get; }
 
         /// <summary>
         /// A factory to use to build expressions to filter a collection of resources of this type by ID.
diff --git a/JSONAPI/Configuration/ResourceTypeConfiguration.cs b/JSONAPI/Configuration/ResourceTypeConfiguration.cs
@@ -19,15 +19,15 @@ public sealed class ResourceTypeConfiguration<TResourceType> : IResourceTypeConf
         internal ResourceTypeConfiguration(IResourceTypeRegistrar resourceTypeRegistrar)
         {
             _resourceTypeRegistrar = resourceTypeRegistrar;
-            RelationshipConfigurations = new ConcurrentDictionary<PropertyInfo, IResourceTypeRelationshipConfiguration>();
+            RelationshipConfigurations = new ConcurrentDictionary<string, IResourceTypeRelationshipConfiguration>();
             ClrType = typeof (TResourceType);
         }
 
         public string ResourceTypeName { get; private set; }
         public Type ClrType { get; private set; }
         public Type DocumentMaterializerType { get; private set; }
         public Func<ResourceTypeRelationship, Type> RelatedResourceMaterializerTypeFactory { get; private set; }
-        public IDictionary<PropertyInfo, IResourceTypeRelationshipConfiguration> RelationshipConfigurations { get; private set; }
+        public IDictionary<string, IResourceTypeRelationshipConfiguration> RelationshipConfigurations { get; private set; }
         public Func<ParameterExpression, string, BinaryExpression> FilterByIdExpressionFactory { get; private set; }
         public Func<ParameterExpression, Expression> SortByIdExpressionFactory { get; private set; }
 
@@ -43,7 +43,7 @@ public void ConfigureRelationship(Expression<Func<TResourceType, object>> proper
             var config = new ResourceTypeRelationshipConfiguration();
             configurationAction(config);
 
-            RelationshipConfigurations[propertyInfo] = config;
+            RelationshipConfigurations[propertyInfo.Name] = config;
         }
 
         public void UseDocumentMaterializer<TMaterializer>()

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ protected override void Load(ContainerBuilder builder)`
`43`	`43`	`{`
`44`	`44`	`IResourceTypeRelationshipConfiguration relationshipConfiguration;`
`45`	`45`	`if (resourceTypeConfiguration.RelationshipConfigurations`
`46`		`- .TryGetValue(relationship.Property, out relationshipConfiguration))`
	`46`	`+ .TryGetValue(relationship.Property.Name, out relationshipConfiguration))`
`47`	`47`	`{`
`48`	`48`	`if (relationshipConfiguration.MaterializerType != null)`
`49`	`49`	`{`
`@@ -109,7 +109,7 @@ protected override void Load(ContainerBuilder builder)`
`109`	`109`
`110`	`110`	`// First, see if they have set an explicit materializer for this relationship`
`111`	`111`	`IResourceTypeRelationshipConfiguration relationshipConfiguration;`
`112`		`- if (configuration.RelationshipConfigurations.TryGetValue(relationship.Property,`
	`112`	`+ if (configuration.RelationshipConfigurations.TryGetValue(relationship.Property.Name,`
`113`	`113`	`out relationshipConfiguration) && relationshipConfiguration.MaterializerType != null)`
`114`	`114`	`return (IRelatedResourceDocumentMaterializer)context.Resolve(relationshipConfiguration.MaterializerType, parameters);`
`115`	`115`