Skip to content

Commit d10b334

Browse files
author
Chris Santero
committed
fix a couple mis-named things
1 parent b963cd6 commit d10b334

5 files changed

Lines changed: 22 additions & 8 deletions

File tree

JSONAPI.AcceptanceTests.EntityFrameworkTestWebApp/DocumentMaterializers/StarshipOfficersRelatedResourceMaterializer - Copy.cs renamed to JSONAPI.AcceptanceTests.EntityFrameworkTestWebApp/DocumentMaterializers/StarshipShipCounselorRelatedResourceMaterializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public StarshipShipCounselorRelatedResourceMaterializer(
2323
_dbContext = dbContext;
2424
}
2525

26-
protected override async Task<StarshipOfficerDto> GeRelatedRecord(string primaryResourceId, CancellationToken cancellationToken)
26+
protected override async Task<StarshipOfficerDto> GetRelatedRecord(string primaryResourceId, CancellationToken cancellationToken)
2727
{
2828
var query = _dbContext.Set<Starship>().Where(s => s.StarshipId == primaryResourceId)
2929
.SelectMany(s => s.OfficerLinks)

JSONAPI.AcceptanceTests.EntityFrameworkTestWebApp/JSONAPI.AcceptanceTests.EntityFrameworkTestWebApp.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
<Compile Include="Controllers\TreesController.cs" />
129129
<Compile Include="CustomEntityFrameworkResourceObjectMaterializer.cs" />
130130
<Compile Include="DocumentMaterializers\StarshipDocumentMaterializer.cs" />
131-
<Compile Include="DocumentMaterializers\StarshipOfficersRelatedResourceMaterializer - Copy.cs" />
131+
<Compile Include="DocumentMaterializers\StarshipShipCounselorRelatedResourceMaterializer.cs" />
132132
<Compile Include="DocumentMaterializers\StarshipOfficersRelatedResourceMaterializer.cs" />
133133
<Compile Include="Models\Building.cs" />
134134
<Compile Include="Models\Comment.cs" />

JSONAPI.Autofac/JsonApiAutofacModule.cs

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,24 @@ protected override void Load(ContainerBuilder builder)
3939
if (resourceTypeConfiguration.DocumentMaterializerType != null)
4040
builder.RegisterType(resourceTypeConfiguration.DocumentMaterializerType);
4141

42-
foreach (var relationshipConfiguration in resourceTypeConfiguration.RelationshipConfigurations)
42+
foreach (var relationship in resourceTypeRegistration.Relationships)
4343
{
44-
var relationship = relationshipConfiguration.Value;
45-
builder.RegisterType(relationship.MaterializerType);
44+
IResourceTypeRelationshipConfiguration relationshipConfiguration;
45+
if (resourceTypeConfiguration.RelationshipConfigurations
46+
.TryGetValue(relationship.Property, out relationshipConfiguration))
47+
{
48+
if (relationshipConfiguration.MaterializerType != null)
49+
{
50+
builder.RegisterType(relationshipConfiguration.MaterializerType);
51+
continue;
52+
}
53+
}
54+
55+
// They didn't set an explicit materializer. See if they specified a factory for this resource type.
56+
if (configuration.RelatedResourceMaterializerTypeFactory == null) continue;
57+
58+
var materializerType = configuration.RelatedResourceMaterializerTypeFactory(relationship);
59+
builder.RegisterType(materializerType);
4660
}
4761
}
4862

JSONAPI.EntityFramework/Http/EntityFrameworkToOneRelatedResourceDocumentMaterializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public EntityFrameworkToOneRelatedResourceDocumentMaterializer(
3434
_dbContext = dbContext;
3535
}
3636

37-
protected override async Task<TRelated> GeRelatedRecord(string primaryResourceId, CancellationToken cancellationToken)
37+
protected override async Task<TRelated> GetRelatedRecord(string primaryResourceId, CancellationToken cancellationToken)
3838
{
3939
var param = Expression.Parameter(typeof(TPrimaryResource));
4040
var accessorExpr = Expression.Property(param, _relationship.Property);

JSONAPI/Http/QueryableToOneRelatedResourceDocumentMaterializer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ protected QueryableToOneRelatedResourceDocumentMaterializer(
2828
public async Task<IJsonApiDocument> GetRelatedResourceDocument(string primaryResourceId, HttpRequestMessage request,
2929
CancellationToken cancellationToken)
3030
{
31-
var record = await GeRelatedRecord(primaryResourceId, cancellationToken);
31+
var record = await GetRelatedRecord(primaryResourceId, cancellationToken);
3232
var baseUrl = _baseUrlService.GetBaseUrl(request);
3333
return _singleResourceDocumentBuilder.BuildDocument(record, baseUrl, null, null); // TODO: allow implementors to specify includes and metadata
3434
}
3535

3636
/// <summary>
3737
/// Gets the query for the related resources
3838
/// </summary>
39-
protected abstract Task<TRelated> GeRelatedRecord(string primaryResourceId, CancellationToken cancellationToken);
39+
protected abstract Task<TRelated> GetRelatedRecord(string primaryResourceId, CancellationToken cancellationToken);
4040
}
4141
}

0 commit comments

Comments
 (0)