add null checks in ResourceTypeRegistration

Chris Santero · Chris Santero · commit 7f6431fb09b2 · 2016-04-29T15:42:51.000-04:00
diff --git a/JSONAPI/Core/ResourceTypeRegistration.cs b/JSONAPI/Core/ResourceTypeRegistration.cs
@@ -4,7 +4,6 @@
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reflection;
-using JSONAPI.Http;
 
 namespace JSONAPI.Core
 {
@@ -22,6 +21,9 @@ internal ResourceTypeRegistration(Type type, PropertyInfo idProperty, string res
             Func<ParameterExpression, string, BinaryExpression> filterByIdExpressionFactory,
             Func<ParameterExpression, Expression> sortByIdExpressionFactory)
         {
+            if (type == null) throw new ArgumentNullException(nameof(type));
+            if (idProperty == null) throw new ArgumentNullException(nameof(idProperty));
+            if (resourceTypeName == null) throw new ArgumentNullException(nameof(resourceTypeName));
             IdProperty = idProperty;
             Type = type;
             ResourceTypeName = resourceTypeName;
@@ -44,11 +46,13 @@ internal ResourceTypeRegistration(Type type, PropertyInfo idProperty, string res
 
         public string GetIdForResource(object resource)
         {
+            if (resource == null) throw new ArgumentNullException(nameof(resource));
             return IdProperty.GetValue(resource).ToString();
         }
 
         public void SetIdForResource(object resource, string id)
         {
+            if (resource == null) throw new ArgumentNullException(nameof(resource));
             IdProperty.SetValue(resource, id); // TODO: handle classes with non-string ID types
         }
 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`	`using System.Linq;`
`5`	`5`	`using System.Linq.Expressions;`
`6`	`6`	`using System.Reflection;`
`7`		`-using JSONAPI.Http;`
`8`	`7`
`9`	`8`	`namespace JSONAPI.Core`
`10`	`9`	`{`
`@@ -22,6 +21,9 @@ internal ResourceTypeRegistration(Type type, PropertyInfo idProperty, string res`
`22`	`21`	`Func<ParameterExpression, string, BinaryExpression> filterByIdExpressionFactory,`
`23`	`22`	`Func<ParameterExpression, Expression> sortByIdExpressionFactory)`
`24`	`23`	`{`
	`24`	`+ if (type == null) throw new ArgumentNullException(nameof(type));`
	`25`	`+ if (idProperty == null) throw new ArgumentNullException(nameof(idProperty));`
	`26`	`+ if (resourceTypeName == null) throw new ArgumentNullException(nameof(resourceTypeName));`
`25`	`27`	`IdProperty = idProperty;`
`26`	`28`	`Type = type;`
`27`	`29`	`ResourceTypeName = resourceTypeName;`
`@@ -44,11 +46,13 @@ internal ResourceTypeRegistration(Type type, PropertyInfo idProperty, string res`
`44`	`46`
`45`	`47`	`public string GetIdForResource(object resource)`
`46`	`48`	`{`
	`49`	`+ if (resource == null) throw new ArgumentNullException(nameof(resource));`
`47`	`50`	`return IdProperty.GetValue(resource).ToString();`
`48`	`51`	`}`
`49`	`52`
`50`	`53`	`public void SetIdForResource(object resource, string id)`
`51`	`54`	`{`
	`55`	`+ if (resource == null) throw new ArgumentNullException(nameof(resource));`
`52`	`56`	`IdProperty.SetValue(resource, id); // TODO: handle classes with non-string ID types`
`53`	`57`	`}`
`54`	`58`