provide more helpful error when the resource ID is null

Chris Santero · Chris Santero · commit 6a2f9682b50a · 2016-04-29T15:56:47.000-04:00
diff --git a/JSONAPI/Core/ResourceTypeRegistration.cs b/JSONAPI/Core/ResourceTypeRegistration.cs
@@ -47,7 +47,9 @@ internal ResourceTypeRegistration(Type type, PropertyInfo idProperty, string res
         public string GetIdForResource(object resource)
         {
             if (resource == null) throw new ArgumentNullException(nameof(resource));
-            return IdProperty.GetValue(resource).ToString();
+            var resourceId = IdProperty.GetValue(resource);
+            if (resourceId == null) throw new ArgumentException($"The ID for the provided `{ResourceTypeName}` resource is null.");
+            return resourceId.ToString();
         }
 
         public void SetIdForResource(object resource, string id)

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,9 @@ internal ResourceTypeRegistration(Type type, PropertyInfo idProperty, string res`
`47`	`47`	`public string GetIdForResource(object resource)`
`48`	`48`	`{`
`49`	`49`	`if (resource == null) throw new ArgumentNullException(nameof(resource));`
`50`		`- return IdProperty.GetValue(resource).ToString();`
	`50`	`+ var resourceId = IdProperty.GetValue(resource);`
	`51`	+ if (resourceId == null) throw new ArgumentException($"The ID for the provided `{ResourceTypeName}` resource is null.");
	`52`	`+ return resourceId.ToString();`
`51`	`53`	`}`
`52`	`54`
`53`	`55`	`public void SetIdForResource(object resource, string id)`