use model manager method to determine if relationship is to-many

Chris Santero · Chris Santero · commit 343ff012c4e4 · 2015-02-21T22:35:01.000-05:00
diff --git a/JSONAPI/Json/JsonApiFormatter.cs b/JSONAPI/Json/JsonApiFormatter.cs
@@ -797,8 +797,7 @@ private void DeserializeLinkedResources(object obj, JsonReader reader)
                     PropertyInfo prop = _modelManager.GetPropertyForJsonKey(objectType, value);
                     if (prop != null && !prop.PropertyType.CanWriteAsJsonApiAttribute())
                     {
-                        //FIXME: We're really assuming they're ICollections...but testing for that doesn't work for some reason. Break prone!
-                        if (prop.PropertyType.GetInterfaces().Contains(typeof(IEnumerable)) && prop.PropertyType.IsGenericType)
+                        if (_modelManager.IsSerializedAsMany(prop.PropertyType))
                         {
                             // Is a hasMany
 

Original file line number	Diff line number	Diff line change
`@@ -797,8 +797,7 @@ private void DeserializeLinkedResources(object obj, JsonReader reader)`
`797`	`797`	`PropertyInfo prop = _modelManager.GetPropertyForJsonKey(objectType, value);`
`798`	`798`	`if (prop != null && !prop.PropertyType.CanWriteAsJsonApiAttribute())`
`799`	`799`	`{`
`800`		`- //FIXME: We're really assuming they're ICollections...but testing for that doesn't work for some reason. Break prone!`
`801`		`- if (prop.PropertyType.GetInterfaces().Contains(typeof(IEnumerable)) && prop.PropertyType.IsGenericType)`
	`800`	`+ if (_modelManager.IsSerializedAsMany(prop.PropertyType))`
`802`	`801`	`{`
`803`	`802`	`// Is a hasMany`
`804`	`803`