Repository navigation
Проектная №1 - #1
Open
IsaevMilan wants to merge 3 commits into
Open
IsaevMilan wants to merge 3 commits into
IsaevMilan wants to merge 3 commits into
Conversation
faritowich
reviewed
Jan 13, 2023
| System.out.println("Количество людей не может быть меньше " + MIN_USER_COUNT); | ||
| } | ||
| } | ||
| final PricePlurals formatter = new PricePlurals(); |
There was a problem hiding this comment.
Можно сделать метод у класса PricePlurals тоже static, как и его поля, чтобы не пришлось создавать единственный экземпляр класса для однократного использования
| private final int peopleCount; | ||
| private final PricePlurals formatter; | ||
|
|
||
| public Calculator(BufferedReader reader, int peopleCount, PricePlurals formatter) { |
There was a problem hiding this comment.
В конструктор лучше передавать то, чтобы необходимо снаружи класса передать внутрь класса для использования им. Если что-то можно и так создать внутри класса, то лучше так и сделать. Например, экземпляр BufferedReader можно создать внутри класса Calculator, PricePlurals сделать static
| goodList.add(good); | ||
| totalPrice += price; | ||
| System.out.println("Товар успешно добален"); | ||
| System.out.println("Напишите любой символ для добавления товара\n" + "или слово \"Завершить\" если хотите перейти к расчетам "); |
There was a problem hiding this comment.
Такие подряд идущие println можно объединить в один.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Сдаю проектную работу!