Skip to content

Port IronLanguages/ironpython3#1643 to ironpython2 for #838. - #839

Merged
slozier merged 1 commit into
IronLanguages:masterfrom
mickp:map_838
Feb 5, 2024
Merged

slozier merged 1 commit into
IronLanguages:masterfrom
mickp:map_838

Conversation

@mickp

@mickp mickp commented Feb 3, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@mickp

mickp commented Feb 3, 2024

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@mickp

mickp commented Feb 3, 2024

Copy link
Copy Markdown
Contributor Author

Unfortunately, I'm unable to run the tests - I see errors on build relating to the use of file as a type name:
loadtypesample.cs(110, 18): [CS9056] Types and aliases cannot be named 'file'.
loadtypesample.cs(110, 18): [CS9056] Types and aliases cannot be named 'file'.

@slozier slozier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickp Thanks for the PR. Seems fine so I'll merge it. Will have to see if I can get ipy2 building again...

@slozier
slozier merged commit d834e17 into IronLanguages:master Feb 5, 2024
@mickp
mickp deleted the map_838 branch February 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants