Support default value for structs, such as default(CancellationToken) #817

Activity

1. bnuzhouwei

   changed the title [-]Default value for default(CancellationToken)[/-] [+]Support default value for structs, such as default(CancellationToken)[/+] on May 25, 2022
2. slozier

   added

   confirmed

   Port to ipy3

   on May 27, 2022
3. slozier commented on May 27, 2022

   

   slozier

   on May 27, 2022

   Last edited by slozier

   Contributor

   More actions

   Thanks for the report, I managed to reproduce this with something like:

   public void Test(CancellationToken token = default);

   A potential fix would be to add some sort of check to DefaultArgBuilder.ToExpression in the DLR (don't think this is correct but something similar may work):

   if (parameterType.IsValueType) {
       // default(T)
       return AstUtils.Constant(Activator.CreateInstance(parameterType));
   }
4. bnuzhouwei commented on May 27, 2022

   

   bnuzhouwei

   on May 27, 2022

   Author

   More actions

   Thanks, can we do this without modified the IronPython Souce Code?

   DefaultArgBuilder.ToExpression
   
5. slozier commented on May 28, 2022

   

   slozier

   on May 28, 2022

   Contributor

   More actions

   Thanks, can we do this without modified the IronPython Souce Code?

   I don't have any workaround, I think you will have to explicitly pass in the argument CountDocuments[BsonDocument]("collection", cancellationToken=CancellationToken.None).