Skip to content

Add support for PHP 8 versions - #23

Merged
CMalvika merged 15 commits into
masterfrom
dev/update-php-8
Mar 18, 2022
Merged

Add support for PHP 8 versions#23
CMalvika merged 15 commits into
masterfrom
dev/update-php-8

Conversation

@CMalvika

@CMalvika CMalvika commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Opening this PR but not ready to merge until below dependencies have latest releases:

  • internations/solr-utils
  • internations/testing-component

@CMalvika
CMalvika requested a review from lstrojny March 1, 2022 19:20
@CMalvika

Copy link
Copy Markdown
Contributor Author

Opening this PR but not ready to merge until below dependencies have latest releases:

  • internations/solr-utils
  • internations/testing-component

@lstrojny No named argument tag is added here.

@lstrojny lstrojny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I've added an AnnotationsTest that checks that all methods with parameters have a @no-named-arguments annotation.

@CMalvika

Copy link
Copy Markdown
Contributor Author

Looks good!

I've added an AnnotationsTest that checks that all methods with parameters have a @no-named-arguments annotation.

Wow! Thanks a lot for adding the test. I will merge it now.

@CMalvika
CMalvika merged commit 49f881f into master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants