Fixing HTML change breakin LIKE and COMMENT by eneasz · Pull Request #5296 · InstaPy/InstaPy

eneasz · 2020-01-21T23:23:58Z

No description provided.

…e fix

mountainlion0523 · 2020-01-22T08:14:24Z

it worked, THX!!! X)

ronmara · 2020-01-22T14:29:17Z

-    "unlike": "//section/span/button/span[@aria-label='Unlike']",
-}
+xpath["like_image"] = { "like": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Like']",
+                        "unlike": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Unlike']",


Change the length of the rows to pass the test

ronmara · 2020-01-22T15:13:49Z

-                        }
+xpath["like_image"] = {
+    "like": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Like']",
+    "unlike": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Unlike']",


this row is still too long

@ronmara I've split line in half, some tests have passed some failed. What is the actual requirement that is failing it on 83a3702?

I'm not sure, but try to format the file with black and check the tox.ini file

I suggest using a relative path instead of an absolute path
try using:
xpath["like_image"] = { "like": "//section/span/button[*[local-name()='svg']/@aria-label='Like']", "unlike": "//section/span/button[*[local-name()='svg']/@aria-label='Unlike']", }

wrong file name

…neasz/InstaPy into bugfix/fixing-like-comment_html_change

…allation failing when it tries to install PyYAML-5.3, and it fails with error message: PyYAML requires Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.* but the running Python is 3.4.8

eneasz · 2020-01-22T20:16:01Z

I have decided to remove Python 3.4.8 from tests in .travis.yml as:

I don't have it to be able to find out a working version that would be accepted by this and other versions
There is no official docker images for this python version for me to experiment with fixing it, therefore, I assume it's obsolete

The fix would be to replace PyYAML>=3.13 in requirements.txt with a working version.

This is the error caused during the build for testing in travis-ci

https://files.pythonhosted.org/packages/3d/d9/ea9816aea31beeadccd03f1f8b625ecf8f645bd66744484d162d84803ce5/PyYAML-5.3.tar.gz PyYAML requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.8

lizozom · 2020-01-22T21:49:44Z

 [testenv]
 deps =
-    -rrequirements.txt
+    -r requirements.txt


Hey, is this added space a typo?

lizozom

Changes tested and the fix the issue locally.

TRiXXER76 · 2020-01-22T22:33:59Z

I just updated instapy and to be sure I also edited the code inside the xpath_compile.py

Picture are being liked but comments still not work... I dont even know if hes trying to comment because it just printed "--> not commented" and no error...

eneasz · 2020-01-25T10:10:18Z

I just updated instapy and to be sure I also edited the code inside the xpath_compile.py

Picture are being liked but comments still not work... I dont even know if hes trying to comment because it just printed "--> not commented" and no error...

Comments do work

eganay · 2020-01-25T16:43:30Z

thank you guys

timgrossmann · 2020-01-27T13:11:20Z

Working and ready to merge? 😄

eneasz · 2020-01-27T13:23:24Z

Working and ready to merge? 😄

Yes @timgrossmann :)

Fixing HTML change breakin LIKE and COMMENT

7d75ac6

eneasz requested a review from breuerfelix January 21, 2020 23:24

eneasz mentioned this pull request Jan 21, 2020

Invalid Like Element! #5287

Closed

Removing previously commented out code that has been replaced with th…

e4bed9e

…e fix

eneasz mentioned this pull request Jan 21, 2020

Comment Button Not Found! #5289

Closed

ronmara reviewed Jan 22, 2020

View reviewed changes

Refactoring row lenght in like_image xpath to be able to pass test

35a1e7a

ronmara reviewed Jan 22, 2020

View reviewed changes

Damian and others added 4 commits January 22, 2020 15:14

spliting like/unlike image path to be able to pass tests

83a3702

Yet another shortening like_image line

86af99c

Passing tox tests

a0bb5fd

wrong file name

fae663e

ronmara mentioned this pull request Jan 22, 2020

--> Not commented #5297

Closed

Damian and others added 7 commits January 22, 2020 19:07

using a relative path instead of an absolute path

c148b65

Removing python 3.4 tests due to requirements collision

abbd7f7

Trying to fix build

5e1ec32

Merge pull request #1 from ronmara/patch-1

2e4d44e

wrong file name

Fixing typo in tox.ini

f109c20

Merge branch 'bugfix/fixing-like-comment_html_change' of github.com:e…

2f843b1

…neasz/InstaPy into bugfix/fixing-like-comment_html_change

I have no Python 3.4.8 , the build error is caused by dependency inst…

8707d0c

…allation failing when it tries to install PyYAML-5.3, and it fails with error message: PyYAML requires Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.* but the running Python is 3.4.8

lizozom reviewed Jan 22, 2020

View reviewed changes

Comment thread tox.ini

[testenv]

deps =

-rrequirements.txt

-r requirements.txt

Copy link
Copy Markdown

lizozom Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, is this added space a typo?

lizozom reviewed Jan 22, 2020

View reviewed changes

Abdulsamipy mentioned this pull request Jan 23, 2020

Couldn't follow 'Username'! ~user is inaccessible #5298

Closed

timgrossmann added 2 commits January 28, 2020 10:28

up version

d45f7fa

Update CHANGELOG.md

50ab36c

timgrossmann approved these changes Jan 28, 2020

View reviewed changes

timgrossmann merged commit 95fc624 into InstaPy:master Jan 28, 2020

Conversation

eneasz commented Jan 21, 2020

Uh oh!

mountainlion0523 commented Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronmara Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

ronmara Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

eneasz Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

ronmara Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

zipsoft Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

eneasz commented Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizozom Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

TRiXXER76 commented Jan 22, 2020

Uh oh!

eneasz commented Jan 25, 2020

Uh oh!

eganay commented Jan 25, 2020

Uh oh!

timgrossmann commented Jan 27, 2020

Uh oh!

eneasz commented Jan 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mountainlion0523 commented Jan 22, 2020 •

edited

Loading

eneasz commented Jan 22, 2020 •

edited

Loading