This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Destination device address#101
Merged
Merged
Conversation
Signed-off-by: Chris Jackson <[email protected]>
cdjackson
force-pushed
the
destination_device_address
branch
4 times, most recently
from
e38c3d6 to
776eb17
Compare
Collaborator
|
Hi guys I'm receiving tons of emails from Codacy with the following subject: |
Signed-off-by: Chris Jackson <[email protected]>
cdjackson
force-pushed
the
destination_device_address
branch
from
776eb17 to
d210416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #95. I've now updated the doc and removed commented code.
This changes the ZigBeeDestination to ZigBeeAddress, and then has two address classes - ZigBeeGroupAddress, and ZigBeeDeviceAddress. ZigBeeDevice no longer extends ZigBeeDestination - nothing relied on this extension, and it seems much better not to have this link.
It also makes ZigBeeAddress abstract, and then move the isGroup method into the implementation classes rather than having the parent class check for subclasses to see if it's a group which doesn't seem nice.
In general, everywhere where we had a network address and endpoint, I'm now using the address. It likely needs a bit more work, but I'd welcome your thoughts on wether or not you're happy with this approach.