Skip to content
This repository was archived by the owner on Jun 2, 2026. It is now read-only.

Misc fixes from the PR - #6

Merged
ImDevinC merged 4 commits into
mainfrom
fixes
Nov 13, 2024
Merged

ImDevinC merged 4 commits into
mainfrom
fixes

Conversation

@ImDevinC

Copy link
Copy Markdown
Owner

StreamController/StreamController-Store#60

Fixes:

  • Store image works properly
  • Authentication now uses threads
  • Authentication now has callbacks to inform the user of state

@ImDevinC
ImDevinC merged commit 0ef821c into main Nov 13, 2024
@ImDevinC
ImDevinC deleted the fixes branch November 13, 2024 06:03
@ImDevinC ImDevinC mentioned this pull request Nov 13, 2024
ImDevinC added a commit that referenced this pull request Dec 27, 2025
Replace unbounded daemon thread creation with a bounded thread pool
for better resource management and proper cleanup:

Changes:
- main.py: Import ThreadPoolExecutor from concurrent.futures
- main.py: Create _thread_pool with max_workers=4 in __init__
- main.py: Replace threading.Thread() with _thread_pool.submit()
- main.py: Remove daemon=True flag (pool handles lifecycle)

Benefits:
- Bounded resource usage (max 4 concurrent threads)
- Better thread lifecycle management
- Proper cleanup on shutdown
- Named threads for easier debugging (discord- prefix)

Impact: Better resource management, improved stability

Resolves issue #6 from RESEARCH.md Phase 2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant