Repository navigation
Conversation
doc-ODA
reviewed
Dec 25, 2023
| Product newProduct = new Product(item, itemCost); | ||
| System.out.println("Товар успешно добавлен."); | ||
| sum += newProduct.cost; | ||
| items += "\n" + newProduct.name + " " + newProduct.cost; |
There was a problem hiding this comment.
я бы советовал сделать ArrayList вместо String items; и там хранить созданные объекты. Строки не изменяемый тип и при конкатенации строк, вы создаете новый экземпляр строки в памяти(пуле строк). Советую в свободное время об этом почитать, про это часто спрашивают на собеседованиях) И использовать функцию с циклом для создания строки, когда нужно ее вывести на экран.
doc-ODA
reviewed
Dec 28, 2023
| } | ||
|
|
||
| public String toString() { | ||
| return name + " " + cost ; |
There was a problem hiding this comment.
тут бы хорошо смотрелся String.format(), можешь если время есть почитать про него и регулярные выражения, темы интересные и полезные. Заучивать их не нужно, но ознакомиться рекомендую)
Owner
Author
|
Постарался добавить в выводах String.format(), поправил логику. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.