chore(desktop): keep the lint run away from build output - #240
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
bun run lint(ultracite check) no longer hangs when a build output directory exists. The devwatcher rebuilds
apps/desktop/dist/on every source edit, so the failure used to appear at randomduring ordinary development: the run burned a core for minutes and then reported an error over the
bundled renderer's embedded xterm banner.
Cause, verified on the live checkout: ultracite runs
oxlint .andoxfmt --check ..oxlinthonours this repo's
ignorePatterns(dist/**,build/**, …) and finished in seconds, whileapps/desktop/oxfmt.config.tsignored onlysrc-tauri/gen,src-host, asset JSON andartifacts,so the formatter walked the ~48 MB bundled renderer — including a 5 MB vendor bundle — on every run.
oxfmt.config.tsnow ignores**/dist/**and**/build/**, with the reason recorded beside them.Change record
The linked change directory owns scope, authorization, acceptance, evidence, and residual risk.
Review and release
dist/present (48 MB)bun run lintfinished in 8.8 s and
bun run build:renderercompleted (All matched files use the correct format.+✓ built in 24.04s) where the same commands previously never returned; themaintained file verdict is unchanged.
bun run lint,bun run build:renderer,bun script/verify/sdlc.ts --worktree,bun script/verify/docs.ts.