refactor(desktop): quiet the app shell chrome - #238
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Nine chrome marks from the user's review of the running build:
and a 17px trailing gap before the layout control);
entirely so the breadcrumb starts with the project name;
the row title's edge, and the pull-request state now travels by colour, icon and tooltip instead of
a visible "Merged" / "CI failed" word;
+ / voice / send,and the checkout bar's labels move to the quiet grey.
Change record
The linked change directory owns scope, authorization, acceptance, evidence, and residual risk.
Review and release
gaps measured 4/4 against 16/8/17 before, the checkout chip computed to the muted foreground
grey, the header mark is absent from the rendered shell, and the record's AC-1..AC-9 map to
current PASS evidence (rail rows and branch chip are structural plus rendered tests, since the
Core-less renderer has no session data).
bun run lint,bunx tsc --noEmit(insidebuild:renderer),bun test(957 pass / 3 skip / 0 fail),bun run build:renderer,bun script/verify/sdlc.ts --worktree,bun script/verify/docs.ts,git diff --check.