refactor(desktop): unify settings page rhythm and layout - #236
Merged
Merged
Conversation
- converge every settings tab on one 48rem measure - route appearance and memory headings through shared section primitives - align SettingsSection title weight to 600 and render Usage via PageHeader - make `sm` button an alias of the 28px `compact` size - add settingsRhythmContract test and SDLC records
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Settings pages no longer each carry their own layout dialect. One measure, one page-title block, one
section-heading role and weight, one module-card plane, and one 28px button treatment now apply to
every tab:
.settings-page;h2/h3render through the sharedSettingsSection/GroupHeading, and both shared headings now carry the same 14px/600 treatment(rendered verification caught
SettingsSectionat 500 againstGroupHeadingandPageHeaderat600 and the fix is included);
PageHeaderinstead of a hand-rolledh1;fill-quietto the documentedsurfaceplane, with the memory policy columns separated by a hairline instead of a second fill;
size="sm"is now byte-identical tosize="compact", so the 28px control has one look.Change record
The linked change directory owns scope, authorization, acceptance, evidence, and residual risk.
Review and release
settings tabs were driven in the real renderer and measured at 768px, and the UI Lab scenario
captured the shared section anatomy in light and dark (see the record's AC-1..AC-7 evidence).
bun run lint,bunx tsc --noEmit,bun test(940 pass / 3 skip /0 fail),
bun run build:renderer,bun script/verify/sdlc.ts --worktree,bun script/verify/docs.ts, andgit diff --check.