Fix bug in complex SVD LAPACK calls - #337
Merged
Merged
Conversation
Contributor
|
Thanks for continuing to keep an eye on this new code |
strandn
pushed a commit
to tgingrich/ITensor
that referenced
this pull request
Nov 9, 2020
Fix bug in complex SVD LAPACK calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately there was a bug in my PR #333 -- namely, the size for one of the matrices in the LAPACK routine was too great, causing it to possibly corrupt memory.
I guess it wasn't caught in the unit tests because the SVD still works: it just causes memory errors down the line rather than straight away.
I noticed there are additional improvements which could be done with all the LAPACK routines (not just the SVDs) with regards to LWORK but I wanted to get this bugfix out straight away.