Skip to content

Does not respect stop_on_error #467

@shzhng

Description

@shzhng

IRKernel currently doesn't respect the "stop_on_error" field in the Jupyter Message Protocol"
https://jupyter-client.readthedocs.io/en/latest/messaging.html#execute

Even if you pass "stop_on_error": false in the execute_request header, IRkernel will abort the remaining execution queue.

Needs to be an extra check here to see if stop_on_error.

if (interrupted || !is.null(err$ename)) {

abort_queued_messages = function() {

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions