refactor: normalize code style and formatting across repo#1114
refactor: normalize code style and formatting across repo#1114remivanboxem wants to merge 1 commit intoINGInious:mainfrom
Conversation
- Added `Ruff` dependency and rules inside `pyproject.toml` - Format the entire project using `ruff --config pyproject.toml format inginious/` command. This change will allow to have a clearer codebase and should not add regression.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 2 high |
| Security | 56 high 1 critical 1 medium |
| Complexity | 36 medium |
🟢 Metrics 7 complexity · 6 duplication
Metric Results Complexity 7 Duplication 6
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
The changes proposed sometimes seem way less readable than the previous lines due to an abusive use of new lines. Is this really the recommended standard ? In any case I'm not sure we would need to update the entire codebase once because it would break any work made above: our work, but also community work that we want to respect even if those changes don't come back to upstream. I think this is something we could simply set for future PRs. Time would do the necessary and replace the old code. However I'd like another thought on this (@nrybowski) because I dont really facny having a lot of new lines everywhere. |
2 participants
Ruffdependency and rules insidepyproject.tomlruff --config pyproject.toml format inginious/command.This change allows having a clearer codebase and should not add regression. To enforce this stylistic change, maintainers can either: