Repository navigation
Change how language is handled - #179
Merged
SupahNickie merged 3 commits intoOct 19, 2018
Merged
SupahNickie merged 3 commits into
SupahNickie merged 3 commits into
Conversation
Contributor
|
#177 has a goal for a publisher to use their "own geo IP vendor relationship". Is that objective handled somehow in this PR? |
Author
|
That functionality is already in production from earlier. There's a configuration option called "geoIPVendor" that is used to control that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configuration option
useGeolocationOnlyset tofalseby default. If the publisher sets this new option to true, the language check will be skipped.Closes #177, #176