Feature utils by HandsomeCoder · Pull Request #4 · HandsomeCoder/java-utility

HandsomeCoder · 2022-05-07T16:43:20Z

Added Utilities and their test cases

sonatype-lift · 2022-05-07T16:45:06Z

+     * @param values  the values
     * @author Harsh Shah
     */
    public static void success(String message, Object... values) {


AnnotateFormatMethod: This method passes a pair of parameters through to String.format, but the enclosing method wasn't annotated @FormatMethod. Doing so gives compile-time rather than run-time protection against malformed format strings.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T16:45:07Z

+        builder.setNumberOfQuery(0);
+
+        try {
+            URI uri = new URI(url);


UnusedVariable: The local variable 'uri' is never read.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T16:45:09Z

+        try {
+            URI uri = new URI(url);
+        } catch (URISyntaxException e) {
+            e.printStackTrace();


CatchAndPrintStackTrace: Logging or rethrowing exceptions should usually be preferred to catching and calling printStackTrace

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T16:45:11Z

+        try {
+            response = HttpClient.newHttpClient().send(request, HttpResponse.BodyHandlers.ofString());
+        } catch (IOException | InterruptedException e) {
+            e.printStackTrace();


CatchAndPrintStackTrace: Logging or rethrowing exceptions should usually be preferred to catching and calling printStackTrace

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T16:45:12Z

+     * @param values  the values
     * @author Harsh Shah
     */
    public static void error(String message, Object... values) {


AnnotateFormatMethod: This method passes a pair of parameters through to String.format, but the enclosing method wasn't annotated @FormatMethod. Doing so gives compile-time rather than run-time protection against malformed format strings.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T16:45:13Z

-
        char[] characters = jsonString.toCharArray();
-
        Stack<ClosingCharacterModel> stack = new Stack<>();


JdkObsolete: Stack is a nonstandard class that predates the Java Collections Framework; prefer ArrayDeque. Note that the Stack methods push/pop/peek correspond to the Deque methods addFirst/removeFirst/peekFirst.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T17:23:15Z

+        try {
+            response = HttpClient.newHttpClient().send(request, HttpResponse.BodyHandlers.ofString());
+        } catch (IOException | InterruptedException e) {
+            e.printStackTrace();


CatchAndPrintStackTrace: Logging or rethrowing exceptions should usually be preferred to catching and calling printStackTrace

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T17:23:16Z

+     * @param values  the values
     * @author Harsh Shah
     */
    public static void success(String message, Object... values) {


AnnotateFormatMethod: This method passes a pair of parameters through to String.format, but the enclosing method wasn't annotated @FormatMethod. Doing so gives compile-time rather than run-time protection against malformed format strings.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T17:23:17Z

+     * @param values  the values
     * @author Harsh Shah
     */
    public static void error(String message, Object... values) {


AnnotateFormatMethod: This method passes a pair of parameters through to String.format, but the enclosing method wasn't annotated @FormatMethod. Doing so gives compile-time rather than run-time protection against malformed format strings.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T17:23:18Z

+        try {
+            URI uri = new URI(url);
+        } catch (URISyntaxException e) {
+            e.printStackTrace();


CatchAndPrintStackTrace: Logging or rethrowing exceptions should usually be preferred to catching and calling printStackTrace

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T17:23:20Z

-
        char[] characters = jsonString.toCharArray();
-
        Stack<ClosingCharacterModel> stack = new Stack<>();


JdkObsolete: Stack is a nonstandard class that predates the Java Collections Framework; prefer ArrayDeque. Note that the Stack methods push/pop/peek correspond to the Deque methods addFirst/removeFirst/peekFirst.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T17:23:21Z

+        builder.setNumberOfQuery(0);
+
+        try {
+            URI uri = new URI(url);


UnusedVariable: The local variable 'uri' is never read.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

HandsomeCoder added 5 commits April 20, 2022 22:31

Added ObjectUtils and Test Cases

d8aacd9

Updated dependencies

c60028c

Added HttpClient Utils

86c017b

Added Test Cases

c02191f

Enchanced test cases to improve code coverage

0b9dab8

sonatype-lift Bot reviewed May 7, 2022

View reviewed changes

Fix Sonatype Lift

02e4586

sonatype-lift Bot reviewed May 7, 2022

View reviewed changes

Fixed Sonatype lift issues

12fb531

HandsomeCoder merged commit f1e38ce into main May 7, 2022

Navigation Menu

Repository navigation

Feature utils - #4

Feature utils#4
HandsomeCoder merged 7 commits into
mainfrom
feature-utils

HandsomeCoder commented May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant


		char[] characters = jsonString.toCharArray();

		Stack<ClosingCharacterModel> stack = new Stack<>();

Conversation

HandsomeCoder commented May 7, 2022

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 7, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant