Convert dict to string#73
Closed
PrajwalM2212 wants to merge 1 commit into
Closed
Conversation
Closed
Contributor
|
not passing CI |
Contributor
Author
|
@Mec-iS One of the reason for travis failing was this issue. But to make the CI pass we have to remove the dependency on https://storage.googleapis.com/api4/api. |
Member
|
@sandeepsajan0 Please review |
| properties=entrypoint_properties) | ||
| self.redis_graph.add_node(entrypoint_node) | ||
| redis_connection.set("EntryPoint", entrypoint_properties) | ||
| redis_connection.set("EntryPoint", json.dumps(entrypoint_properties)) |
Contributor
There was a problem hiding this comment.
@PrajwalM2212 I think, we don't need to have that line of code because we already have a node for the same. So, Can you try to run without this line? And don't forget to send the screenshot.
Closed
Contributor
|
waiting for feedback from @PrajwalM2212 |
Contributor
|
What' the status here? Without removing that line, |
Contributor
|
fixed in #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #72
redis_connection.setaccepts a string as its value , but a dictionary was passed. This has been solved by using json.dumps.