Move the autoplay check into the constructor

ericdrobinson · ericdrobinson · commit c0e868484a64 · 2017-12-12T13:09:35.000-05:00
The `autoplay` option only makes sense in the constructor. After that, callers of `setMusic` should determine whether or not to begin playback based on their own state.
diff --git a/src/APlayer.js b/src/APlayer.js
@@ -434,6 +434,11 @@ class APlayer {
             this.setMusic(0);
         }
 
+        // autoplay
+        if (this.option.autoplay && !this.isMobile) {
+            this.play();
+        }
+
         instances.push(this);
     }
 
@@ -717,12 +722,6 @@ class APlayer {
         if (this.audio.duration !== 1) {           // compatibility: Android browsers will output 1 at first
             this.element.getElementsByClassName('aplayer-dtime')[0].innerHTML = this.audio.duration ? this.secondToTime(this.audio.duration) : '00:00';
         }
-
-        // autoplay
-        if (this.option.autoplay && !this.isMobile) {
-            this.play();
-        }
-        this.option.autoplay = true;  // autoplay next music
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -434,6 +434,11 @@ class APlayer {`
`434`	`434`	`this.setMusic(0);`
`435`	`435`	`}`
`436`	`436`
	`437`	`+ // autoplay`
	`438`	`+ if (this.option.autoplay && !this.isMobile) {`
	`439`	`+ this.play();`
	`440`	`+ }`
	`441`	`+`
`437`	`442`	`instances.push(this);`
`438`	`443`	`}`
`439`	`444`
`@@ -717,12 +722,6 @@ class APlayer {`
`717`	`722`	`if (this.audio.duration !== 1) { // compatibility: Android browsers will output 1 at first`
`718`	`723`	`this.element.getElementsByClassName('aplayer-dtime')[0].innerHTML = this.audio.duration ? this.secondToTime(this.audio.duration) : '00:00';`
`719`	`724`	`}`
`720`		`-`
`721`		`- // autoplay`
`722`		`- if (this.option.autoplay && !this.isMobile) {`
`723`		`- this.play();`
`724`		`- }`
`725`		`- this.option.autoplay = true; // autoplay next music`
`726`	`725`	`}`
`727`	`726`
`728`	`727`	`/**`