replace map with forEach

DIYgod · DIYgod · commit 6c9dcdbbd6cf · 2018-03-20T00:35:22.000+08:00
diff --git a/src/js/events.js b/src/js/events.js
@@ -22,10 +22,10 @@ class Events {
         }
     }
 
-    trigger (name, info) {
+    trigger (name, data) {
         if (this.events[name] && this.events[name].length) {
             for (let i = 0; i < this.events[name].length; i++) {
-                this.events[name][i](info);
+                this.events[name][i](data);
             }
         }
     }
diff --git a/src/js/timer.js b/src/js/timer.js
@@ -20,9 +20,8 @@ class Timer {
     }
 
     init () {
-        this.types.map((item) => {
+        this.types.forEach((item) => {
             this[`init${item}Checker`]();
-            return item;
         });
     }
 
@@ -64,10 +63,9 @@ class Timer {
     }
 
     destroy () {
-        this.types.map((item) => {
+        this.types.forEach((item) => {
             this[`enable${item}Checker`] = false;
             this[`${item}Checker`] && clearInterval(this[`${item}Checker`]);
-            return item;
         });
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -22,10 +22,10 @@ class Events {`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`
`25`		`- trigger (name, info) {`
	`25`	`+ trigger (name, data) {`
`26`	`26`	`if (this.events[name] && this.events[name].length) {`
`27`	`27`	`for (let i = 0; i < this.events[name].length; i++) {`
`28`		`- this.events[name][i](info);`
	`28`	`+ this.events[name][i](data);`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,8 @@ class Timer {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`init () {`
`23`		`- this.types.map((item) => {`
	`23`	`+ this.types.forEach((item) => {`
`24`	`24`	this[`init${item}Checker`]();
`25`		`- return item;`
`26`	`25`	`});`
`27`	`26`	`}`
`28`	`27`
`@@ -64,10 +63,9 @@ class Timer {`
`64`	`63`	`}`
`65`	`64`
`66`	`65`	`destroy () {`
`67`		`- this.types.map((item) => {`
	`66`	`+ this.types.forEach((item) => {`
`68`	`67`	this[`enable${item}Checker`] = false;
`69`	`68`	this[`${item}Checker`] && clearInterval(this[`${item}Checker`]);
`70`		`- return item;`
`71`	`69`	`});`
`72`	`70`	`}`
`73`	`71`	`}`