Remove unnecessary branches in code

ericdrobinson · ericdrobinson · commit 00bec0c66ef1 · 2017-12-12T11:55:39.000-05:00
Modulo operators are perfect for this type of logic.
diff --git a/src/APlayer.js b/src/APlayer.js
@@ -583,12 +583,8 @@ class APlayer {
                             }
                         }
                         else if (this.mode === 'circulation') {
-                            if (this.playIndex < this.option.music.length - 1) {
-                                this.setMusic(++this.playIndex);
-                            }
-                            else {
-                                this.setMusic(0);
-                            }
+                            this.playIndex = (this.playIndex + 1) % this.option.music.length;
+                            this.setMusic(this.playIndex);
                         }
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -583,12 +583,8 @@ class APlayer {`
`583`	`583`	`}`
`584`	`584`	`}`
`585`	`585`	`else if (this.mode === 'circulation') {`
`586`		`- if (this.playIndex < this.option.music.length - 1) {`
`587`		`- this.setMusic(++this.playIndex);`
`588`		`- }`
`589`		`- else {`
`590`		`- this.setMusic(0);`
`591`		`- }`
	`586`	`+ this.playIndex = (this.playIndex + 1) % this.option.music.length;`
	`587`	`+ this.setMusic(this.playIndex);`
`592`	`588`	`}`
`593`	`589`	`}`
`594`	`590`	`}`