Skip to content

Merge tags: show related modifiers by name (MERGE-16) - #18

Merged
zackkatz merged 1 commit into
mainfrom
feature/relation-ids
Sep 28, 2026
Merged

Merge tags: show related modifiers by name (MERGE-16)#18
zackkatz merged 1 commit into
mainfrom
feature/relation-ids

Conversation

@zackkatz

@zackkatz zackkatz commented Sep 27, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

TLDR: Merge this before GravityKit/merge-tags "Name related modifiers by catalog id". That change makes conflicts_with and implies hold catalog ids (gravityforms/raw); without this, the merge tag reference would show "can't be combined with :gravityforms/raw" instead of ":raw". Continues MERGE-16; no new issue by request.

IndexPage.jsx now turns each reference into the name of the modifier it points at, through the artifact's own modifier list. A name passes through unchanged, so the artifact published today renders exactly as it does now.

Checked against the new catalog: gravityview/raw-date-tag shows as raw, and no id is left after mapping across all 91 modifiers. A names-only list passes through unchanged. The JSX parses (esbuild); the page was not rebuilt locally.

Summary by CodeRabbit

  • Bug Fixes
    • Modifier details now display resolved names for “conflicts with” and “implies” relations, including support for artifacts that store relation names directly.

@linear-code

linear-code Bot commented Sep 27, 2026

Copy link
Copy Markdown

MERGE-16

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: e3c94ca2-9b02-4bdb-90fd-e3b771ad1a82

📥 Commits

Reviewing files that changed from the base of the PR and between 36c4fd8 and 7dcd5d5.

📒 Files selected for processing (1)
  • src/components/merge-tags/IndexPage.jsx

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Walkthrough

The merge-tags page now resolves modifier relation references to catalog names when possible. It preserves the supplied reference when no catalog ID matches. Requirement display is unchanged.

Changes

Modifier relation display

Layer / File(s) Summary
Resolve and display modifier relation references
src/components/merge-tags/IndexPage.jsx		 The page maps modifier IDs to catalog names, then uses those names for conflicts_with and implies. Unmatched references remain displayed as supplied.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 7dcd5

The page resolves known relation IDs to modifier names and preserves unmatched references. No concrete display regression is established; the unavailable external catalog leaves a narrow unverified case, not a demonstrated reason to block this change.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: displaying related modifiers by name in merge tags. It includes the relevant issue identifier.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@zackkatz
zackkatz merged commit 11415d5 into main Sep 28, 2026
1 check passed
@zackkatz
zackkatz deleted the feature/relation-ids branch September 28, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@zackkatz