Conversation
product-auto-label
Bot
added
the
samples
leahecole
added
the
kokoro:force-run
leahecole
marked this pull request as ready for review
August 15, 2022 19:58
leahecole
requested review from
a team,
rachael-ds and
rafalbiegacz
as code owners
August 15, 2022 19:58
blunderbuss-gcf
Bot
removed
the
blunderbuss: assign
leahecole
changed the title
bradmiro
reviewed
Aug 15, 2022
| # Retry if we see a flaky 409 "subnet not ready" exception | ||
| @backoff.on_exception(backoff.expo, Aborted, max_tries=3) | ||
| def test_process(test_bucket): | ||
| def test_process(test_bucket, test_dataproc_batch): |
Collaborator
There was a problem hiding this comment.
I am definitely rusty on my pytest but are you possibly creating two test buckets by referencing it in both bq_dataset and test_process?
Contributor
There was a problem hiding this comment.
They are both defined as scope="module" so will only create the object once in this case.
Collaborator
Author
There was a problem hiding this comment.
Yup! What Charlie said 😁
kokoro-team
removed
the
kokoro:force-run
engelke
approved these changes
Aug 16, 2022
bradmiro
approved these changes
Aug 17, 2022
Collaborator
Author
|
Ugh, I don't see this failure locally but I'll debug in a bit and see if I can fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#8021 was similar but was throwing the
Abortederror, this is giving a 409AlreadyExistswhich was happening when it would retry but already find a batch there. I've added teardown logic to hopefully reduce the likelihood that anAlreadyExistshappens.Fixes #8254
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)