chore(compute): Changing the default zone for compute api tests - #7463
Merged
Merged
Conversation
product-auto-label
Bot
added
api: compute
m-strzelczyk
marked this pull request as ready for review
February 16, 2022 14:26
Contributor
Author
Yes. Thanks for catching this! |
dandhlee
approved these changes
Feb 16, 2022
dandhlee
left a comment
dandhlee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I think it's fine to leave the create_instance.py file's region as is, it can be changed by users if needed.
Contributor
Author
|
OK, I'll restore the zone in the sample code. |
busunkim96
approved these changes
Feb 18, 2022
dandhlee
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
leahecole
approved these changes
Feb 18, 2022
Collaborator
|
I was on the fence on changing this for samples that's available to users rather than just tests alone, let's add this item to the meeting agenda to discuss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7461
I figure the
us-central1is a bit overused, so there might be more race conditions when tests are running. Going away to Europe should reduce the risk of the race conditions/resource exhaustion.Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)