Skip to content

feat: Target new Datastore Client after microgenerator migration - #4858

Merged
crwilcox merged 17 commits into
masterfrom
test-new-datastore
Nov 12, 2020
Merged

feat: Target new Datastore Client after microgenerator migration#4858
crwilcox merged 17 commits into
masterfrom
test-new-datastore

Conversation

@crwilcox

@crwilcox crwilcox commented Oct 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

do not merge until we release the new version of datastore.

@crwilcox crwilcox added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 15, 2020
@crwilcox
crwilcox requested a review from a team as a code owner October 15, 2020 23:13
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@crwilcox crwilcox changed the title test: target new-generator test: Target new Datastore Client after microgenerator migration. Oct 15, 2020
@crwilcox crwilcox changed the title test: Target new Datastore Client after microgenerator migration. test: Target new Datastore Client after microgenerator migration Oct 15, 2020
@crwilcox crwilcox changed the title test: Target new Datastore Client after microgenerator migration feat: Target new Datastore Client after microgenerator migration Oct 16, 2020
@crwilcox

crwilcox commented Oct 16, 2020

Copy link
Copy Markdown
Contributor Author

This needs to wait until we release the new datastore, at that time, requirements should pin to that version, not a git repo.

@crwilcox crwilcox added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2020
@crwilcox crwilcox mentioned this pull request Oct 16, 2020
Merged
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Oct 16, 2020
dinagraves
dinagraves reviewed Oct 20, 2020
View reviewed changes
Comment thread datastore/cloud-client/admin.py Outdated
Comment thread datastore/cloud-client/quickstart.py Outdated
@crwilcox

crwilcox commented Oct 30, 2020

Copy link
Copy Markdown
Contributor Author

Leaving a note, existing samples pass with firestore 2.0.0dev2 and datastore 2.0.0dev1.

@crwilcox crwilcox removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 10, 2020
@crwilcox
crwilcox requested review from a team and BenWhitehead November 11, 2020 00:52
@dinagraves dinagraves added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2020
@crwilcox
crwilcox merged commit 275b815 into master Nov 12, 2020
@crwilcox
crwilcox deleted the test-new-datastore branch November 12, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@BenWhitehead BenWhitehead BenWhitehead approved these changes
@dinagraves dinagraves dinagraves approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dinagraves dinagraves

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox @BenWhitehead @dinagraves @kokoro-team