BigQuery Storage: update sample application to show new API options. - #1509
Merged
Merged
Conversation
googlebot
added
the
cla: yes
tswast
approved these changes
Jul 12, 2019
lesv
approved these changes
Jul 12, 2019
lesv
left a comment
lesv
left a comment
Contributor
There was a problem hiding this comment.
Did our style guide change? It surprises me to see lines w/ ='s and nothing following when it's short.
https://google.github.io/styleguide/javaguide.html#s4.5.1-line-wrapping-where-to-break
That said, I don't really care if it's important to you. If not, I'd prefer we stick w/ the standard.
Contributor
Author
|
@lesv That's from the coveo code formatter, so I expect it to adhere to the style guide. It seems correct per 4.5.1 (2), breaking after the assignment symbol. |
Contributor
|
SGTM - it looks odd to me, but in time, I'll probably come to love the idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds breadcrumbs for sharding and data format. Doesn't need to deal with row count change since that's handled directly by the library in java via the stream resumption interface.