Skip to content

deps: upgrade enforcer rule to the latest 3.5.0 - #2379

Merged
suztomo merged 7 commits into
GoogleCloudPlatform:masterfrom
suztomo:enforcer_rule_upgrade
Sep 23, 2024
Merged

suztomo merged 7 commits into
GoogleCloudPlatform:masterfrom
suztomo:enforcer_rule_upgrade

Conversation

@suztomo

@suztomo suztomo commented Sep 13, 2024 •

Copy link
Copy Markdown
Contributor

Fixes #2378

Release note of the Maven enforcer rules: https://github.com/apache/maven-enforcer/releases

Based on the proposed changes by Robert Scholte in #2378 (comment)

@suztomo suztomo changed the title deps: upgrade enforcer rule to the latest 3.5.0 [work in progress] deps: upgrade enforcer rule to the latest 3.5.0 Sep 13, 2024
@suztomo

suztomo commented Sep 13, 2024 •

Copy link
Copy Markdown
Contributor Author

TODO: Move to javax.inject from EnforcerRuleHelper in LinkageCheckerRuleTest.

Based on the proposed changes by Robert Scholte in
GoogleCloudPlatform#2378 (comment)
@suztomo

suztomo commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

~/cloud-opensource-java$ mvn integration-test -Dmaven.test.skip -pl enforcer-rules is failing https://github.com/GoogleCloudPlatform/cloud-opensource-java/actions/runs/10855347076/job/30127764204?pr=2379.

@suztomo suztomo changed the title [work in progress] deps: upgrade enforcer rule to the latest 3.5.0 deps: upgrade enforcer rule to the latest 3.5.0 Sep 23, 2024
@suztomo
suztomo marked this pull request as ready for review September 23, 2024 14:18
@suztomo

suztomo commented Sep 23, 2024

Copy link
Copy Markdown
Contributor Author

All checks have passed.

@JoeWang1127 JoeWang1127 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@suztomo
suztomo merged commit 7c7fe4f into GoogleCloudPlatform:master Sep 23, 2024
@suztomo
suztomo deleted the enforcer_rule_upgrade branch September 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enforce-linkage-checker not compatible anymore with recent maven-enforcer-plugin

2 participants