Repository navigation
Publish the reviewed admin shell without replacing it during release - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow rebuilt the Workflow application's UI from mutable HEAD and replaced this plugin's committed contribution/session shell. That discarded the reviewed shell and could remove its session token isolation when publishing a binary.
Release the exact tagged shell instead. Run its session/bearer Node regressions and Go embedding/marker tests before GoReleaser, retain normal clean-tree validation, and remove the unrelated build and temporary npm credential file. Runner labels, tag triggers, release permissions and registry notification are unchanged.
Validation: Node regression tests (2 pass), Go adminui/internal tests pass, actionlint passes. Independent exact-head review and CI are required before tagging v1.1.19. PR51 is already merged; no release tag has been pushed yet.