Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot workflow deletes prior snapshot releases and Git tags before publishing the next release. Stage the exact authority for disabling only that automatic cleanup step, preserving existing releases, assets and Git tags.
This is trust-only staging at
a6e3a598db3bfb0fd9a7ab14ff95b61121f28444: only the three public-workflow presence, action and command allowlists change. They add 1 presence, 5 action and 48 command rows for future pre-release workflow contexte2f8089428c6bd42d84864f9df33873a63b7e4ba4733769915f594f6027a69a4. Every existing row is retained unchanged and ordered. Workflow source is unchanged.The separately reviewed adoption adds an unconditional false condition and two comments to the cleanup step, plus a Go regression and retention documentation. Keeping the dormant body preserves the existing policy harness's mocked cleanup/error tests. Adoption follows trusted staging integration; promotion follows adoption. Neither later phase is included here.
Validation on the unchanged prepared commits:
fad00efd64ab8004555cfc9ced8f1797852effabebcc2086bc55e97ed3fd256c.Pre-release Snapshot was verified
disabled_manuallyimmediately before opening this draft, with zero queued, in-progress, requested, waiting, pending or action-required runs. Keep it disabled. This PR does not re-enable it or modify any workflow setting, credential, permission, executable pin, analyzer or policy engine. Ordinary hosted PR CI is expected. Performance comparison is deferred and unassessed, not passed.Keep this draft unmerged pending exact-head checks and governance verification. Its three maps overlap benchmark-deferral staging PR #1091: preserve both workflows' distinct row groups when reconciling current main, and retain separate stage → adopt → promote sequencing. Do not replace complete maps with older checkpoints. No protection setting is changed or bypassed.
The future cleanup guard does not remove dormant deletion code or change normal release creation, GHCR publication, the moving snapshot image alias, or inherited
--target mainbehavior. Re-enablement and publication remain separate decisions. No live retention or publication test has been performed, and duplicate/partial publication does not authorize deletion, replacement, force or clobber recovery.