Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark discovery fails before performance comparison because Sonic 1.15.2 emits a compatibility warning when Workflow runs on Go 1.27. Upgrade Sonic to 1.15.4 and its required loader to 0.5.2 in both the root and example module graphs. Add a real package-initialization regression that rejects startup diagnostics rather than filtering them out.
The dependency versions select Sonic's supported native Go 1.27 implementation. This changes the prior JSON fallback path, so runtime serializer validation is included. The benchmark workflow, strict validator, baseline cache, six-sample requirement, permissions, and release policy are unchanged.
This is a standalone change from
main; it does not include the diagnostic changes in #1089.Regression evidence
The test re-executes the actual root test binary with
-test.list=^$, including real dependency initialization, and rejects any stdout/stderr or failed subprocess.Validation
go mod tidy -diffare checked; the example module's matching version/checksum updates prevent CI drift.Doc-reconciliation: clean.
Benchmark and merge holds
The prior hosted artifact used an AMD EPYC 9V74 candidate and AMD EPYC 7763 cached baseline. The strict validator includes CPU identity; those datasets cannot establish a valid comparison. This PR leaves that requirement intact. Its ordinary PR benchmark run will provide fresh evidence, but a missing or incompatible baseline must not be presented as a performance pass.
Keep this PR in draft. Every normal push to
maintriggers automatic snapshot release/tag deletion and a new snapshot/GHCR publication. Those effects are not authorized for this change. No release, snapshot deletion, profile installation, manual workflow rerun, or branch-protection bypass is requested.