Repository navigation
ci: promote matching snapshot test budget - #1077
Merged
Merged
Conversation
Align the automatic snapshot functional package budget with the existing 900-second native gate through the reviewed normal trust lifecycle. Preserve the failed600-second measurement as an unmet performance goal, all functional tests, race checks, child deadlines and security settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native CI already gives the full Go1.27.2 race suite900s, but the automatic snapshot still uses Go's implicit600s. Actual main e13a081 passes153 packages and57 critical parents with wfctl756.516s; its snapshot fails at600.387s. This is a budget-consistency repair, with600s retained as an unmet performance goal and no cache-cause claim.
This is the promote step of the existing normal stage/adopt/promote lifecycle. It changes only .github/public-workflow-command-allowlist.json, .github/public-workflow-action-allowlist.json, .github/public-workflow-presence-allowlist.json. The functional fix is exactly
go test -race ./... -timeout=15min the automatic snapshot. Staging retains current authority; promotion removes only the old snapshot context. All38 authority files, policy code, secrets/executable maps, other workflow contexts, settings, permissions and tests remain unchanged.Validation: unchanged trusted policy passes the complete stage/adopt/promote fixtures and rejects deliberately unstaged adoption. Both independent scope-first/code reviews pass C0/I0; the configured commit hook passes. Base
dc99230fe6869e6ecf4409ecaf069dafc485b8fd, head0ffc448157864b374e7da04bec0e031aac891599, tree527e17ffef0e8a6d1ce248e89bca2b369b154960. This PR's own natural CI/current security/protection checks remain required; actual repaired-main snapshot tests and both publishers must genuinely pass before source acceptance. Original snapshot failures and incomplete scan findings remain recorded. No deployment.