Skip to content

fix(wfctl): retain safe failure evidence for record-host tests - #1065

Merged
intel352 merged 2 commits into
mainfrom
fix/record-host-failure-diagnostics
Oct 15, 2026
Merged

intel352 merged 2 commits into
mainfrom
fix/record-host-failure-diagnostics

Conversation

@intel352

@intel352 intel352 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The live record-host sandbox test previously reported only pipeline_failed, losing the failing operation and cleanup evidence. Add an explicit failure-only diagnostic opt-in with closed phase/status fields, preserve the public record protocol, and report only validated statuses, fixture digests and bounded cleanup counts in the synthetic test.

Deterministic committed tests inject Docker create/attach/wait/status and cleanup failures, synthetic child exits/signals, malformed reports and concurrent observations. Existing assertions, timeouts, race mode, authority manifest, workflows and module pins are unchanged.

This is the separate Task30 diagnostic repair under ADR0186/DR1–DR6. It does not establish the cause of snapshot38643952510 attempt1 or repair production behavior. That original failure remains preserved. Local Go validation stopped at a managed-sandbox denial reading the existing shared Go build cache; no denied-read retry or cache substitution occurred. Prepared-source reviews precede publication; this natural CI must actually execute the injected tests, race/native suite and compatible lint before integration. Actual main/snapshot/final reviews and explicit forward Task23 admission remain due.

The first natural attempt at def8159 is preserved as failed: 12/13 diagnostic parents, the original live Docker test, all18/eight contracts and both real CLI1272 consumers passed; image-setup TempDir cleanup and QF1008 lint failed. The same-scope correction isolates that synthetic subprocess working directory/PATH, disables automatic Go downloads only there, asserts no private Go cache subtree and uses the promoted ExitCode selector. It does not alter production runtime behavior, cache policy, deadlines or assertions. New exact-source natural CI evidence is required; prior successes are historical only.

@intel352
intel352 merged commit 7418f06 into main Oct 15, 2026
23 of 24 checks passed
@intel352
intel352 deleted the fix/record-host-failure-diagnostics branch October 15, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant