Repository navigation
fix(wfctl): wait for valid helper PID in SIGKILL fixture - #1059
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The SIGKILL late-create fixture stopped polling as soon as helper.pid was
readable, even when it was empty and PID parsing failed. Require a successful
positive numeric PID before declaring the helper ready. Preserve the existing
four-second deadline, polling interval, process-group custody and cleanup checks.
This is the one-file corrective Task28 boundary under ADR0180. The original
95f snapshot failure
remains recorded. Main CI on95f passed the same fixture; the exact failing runner
interleaving was not observed.
Validation
Two prepared-source reviews passed with no findings. Local Go execution was
not repeated after a denied cache read. Owning Linux native/race fixture tests,
policy/security/required checks and independent exact-head PR reviews are
required before merge; actual-main and automatic snapshot proof remain required
afterward. No timeout, test skip, production, workflow or protection change.