Repository navigation
ci: adopt strict benchmark collector and quiet Saga logging - #1039
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saga log messages interrupt
BenchmarkSagaConcurrentmeasurements, and the previous collector can accept incomplete comparison output. This change discards logging in that benchmark and adopts the staged strict collector. It validates raw measurements, six samples per series, configuration and CPU identity, and the complete comparison before accepting a result. Raw results and restored baselines remain available as artifacts; the standard baseline cache key and save path are unchanged.The exact two-file candidate is
bd4b736165a5cb64f332bc04f6ea180bfbfc4ca7, based on accepted Task15 main15683f0da55359716c2aa6893c0ad796dccc011c. The full local reference/candidate pair passed strict validation and the existing regression threshold. Native Go1.27.1 analysis covered all 14 modules, retaining the two approved fixture errors and the same 59 residual findings. macOS and Linux each passed all 350 policy tests; trusted scans, static checks and the repaired fixture harness passed. The original harness's exactEVENT_NAME: unbound variableB2 failure remains recorded.Hosted candidate output contains all 240 valid measurements. The hosted comparison rejects the retained Task15 baseline's Saga log output, so no hosted comparison or regression clearance is claimed. That exact legacy-baseline failure and the existing B2 failure use the previously approved narrow dispositions; no CPU, configuration, sample-count, regression or vulnerability exception is added.
After merge, the existing main workflow must save a complete valid baseline at
go-benchmark-main-<actual-merge-sha>. A fresh Task3 PR must restore those hash-identical raw bytes and pass its full strict comparison before Task3 merges. Actual-main, snapshot and image acceptance remain required.