Repository navigation
ci: stage benchmark authority and patch fixture x/text - #1038
Merged
Merged
Conversation
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage the complete unused benchmark collector authority and update the iac-pass/no-iac fixture requirements and checksum pairs to golang.org/x/text v0.42.0, matching the existing root dependency. This repairs their vulnerable v0.38.0 declarations. Collector and quiet logger adoption follows separately.
Local focused conformance, both-OS policy, trusted scan, vet, lint and repaired harness gates passed. Native Go1.27.1 evidence proves four affected fixture finding removals and retains 59 preexisting finding occurrences; two existing fixture tidy diagnostics remain.
PR-head Go1.26.5 tests passed. The CI policy fixture retains its known EVENT_NAME failure. Complete PR OSV old/new JSON differs only by the four intended fixture finding removals; differential SARIF has zero results. Independently reviewed full-object compatibility and 62 focused tests/subtests verify the seven historical advisory modified/related metadata changes at all 98 occurrences, retaining affected versions, finding identity and coverage.
One targeted exact-head benchmark rerun matches the baseline EPYC 7763 CPU and provides 117 paired metric comparisons across 39 series with six samples each. Independent full-raw review found no cost increase reaching the 20% threshold; the largest raw median increase is 11.7103%. The existing logger corrupts six Saga headers in each input, so only the recorded twelve parse diagnostics remain under the separately approved Task15 disposition. The original CPU-mismatched attempt is retained as failed comparison evidence. The legacy wrapper does not record benchstat's exit, and its artifact does not contain a direct restored-cache hash; Task16 and the fresh Task3 proof retain their direct saved/restored hash-equality requirements.
The reviewed source, tests and recorded diagnostic dispositions satisfy the implementation gates. GitHub's ordinary review requirement remains pending. Immediate-main native, hosted, benchmark, snapshot, image and cleanup receipts remain required before advancing to Task16.