Repository navigation
test: compress conformance fixture archives at best speed - #1034
Merged
Merged
Conversation
intel352
changed the title
intel352
changed the title
intel352
marked this pull request as ready for review
October 13, 2026 00:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full Go race suite reached its unchanged ten-minute package limit while compressing a large conformance fixture binary. Use gzip.BestSpeed in the two test-only archive writers to reduce fixture CPU work while retaining actual tar.gz archives and executable plugin contents.
Runtime compression, archive validation, conformance assertions, race/coverage settings, and CI timeouts are unchanged. The final diff contains only cmd/wfctl/plugin_conformance_test.go.
Validation: an isolated standard-library regression used the exact old/new helpers on an existing verified 48MiB release binary. Every tar entry name, mode, size, type, and payload SHA matched, including the original executable bytes, for directory and named-file archive styles. Native and race runs passed. Under race, default compression took 11.96s/12.02s versus 5.35s/5.35s with BestSpeed. Hosted full-suite CI remains authoritative for the package budget.
The public workflow mutation harness is a separately pinned authority member. Its bytes remain identical to main (SHA256 7d209bb35ff3a7a46b22f9a10a920eb30218c3403726d1dac72e0bffd1d914a4). Its existing missing EVENT_NAME fixture-context failure requires the documented staged authority lifecycle and is owned by an active external CI recovery plan. This PR does not change manifests, executable digests, guards, workflows, the pinned harness, or the external owner's PR #1033. The existing policy failure blocks merge until that governed repair is complete.
Opened as a draft for independent exact-head review. Applicable failing or pending checks must pass before merging.