Repository navigation
fix: harden daemon and test lifecycles - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daemon restart waits for the captured process to exit before starting its replacement. Stop leaves PID and socket ownership with the daemon, so a concurrent replacement cannot have its files unlinked after a stale PID read. Background startup waits for a successful Health RPC instead of treating a live PID or socket file as readiness.
A shared gRPC dialer passes the raw Unix-socket path to
net.Dialerfor startup Health, shutdown, and the normal CLI client. This preserves Windows drive paths and path characters that URI parsing would change. The TUI smoke helper bounds nested cross-builds and reaps process trees on Unix and Windows; provider startup surfaces query, scan, iteration, and close errors while retaining row-lock ownership.Validation
C:\socket path as a network authority.#. The Windows restart smoke exercises the production client Health call after start and restart.The source merge and release target
v0.30.41require separate decisions after formal review. Merging this PR does not itself publish the release.