feat: add skip_truncate to channel delete - #271
Merged
Conversation
Soft deleting a channel truncates it, so a channel recreated with the same id comes back empty. ChannelDeleteRequest and ChannelDeleteManyRequest take setSkipTruncate, sent as a query param on the single delete and a body field on the batch delete, both omitted when unset. Co-Authored-By: Claude Opus 5 <[email protected]>
Adding skip_truncate to the existing method changed a public interface signature. Keep it and add a three argument overload beside it, so callers of ChannelService.delete(type, id) still compile. Co-Authored-By: Claude Opus 5 <[email protected]>
yaziine
approved these changes
Sep 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CHA-5241
Problem
Soft deleting a channel also truncates it, so a channel recreated with the same id comes back empty and replies quoting older messages fail. The API gained a
skip_truncateoption that keeps the history, and neither delete request can send it.Solution
ChannelDeleteRequest.setSkipTruncate(boolean)sendsskip_truncateas a query param onDELETE /channels/{type}/{id}, andChannelDeleteManyRequest.setSkipTruncate(boolean)sends it in thechannels/deletebody. Both fields areBooleanand omitted when unset, so existing calls send the same request as before.The server owns the rules:
skip_truncateis rejected together with a hard delete, and only distinct channels are eligible.How to verify
./gradlew test --tests '*ChannelDeleteSkipTruncateTest*'passes (4 tests, no API credentials needed). They assert the query param is on the built request URL when set and absent when null, and that the batch body carries the field only when set../gradlew spotlessCheckpasses.🤖 Generated with Claude Code