PR 51722 patch for 16.2 #51772
Closed
pkozlowski-opensource wants to merge 2 commits intoangular:16.2.xfrom
Closed
Conversation
…1722) When a producer is no longer used, the consumer has to update its internal data structure that keeps track of all producers. There used to be an issue where only half of the stale producers would actually be removed from this data structure, as the intended upper bound of the number of producers to remove would decrease with each removed producer, therefore not reaching all producers that should be removed from the data structure. This commit fixes the issue by truncating the arrays directly, without going through individual `pop` operations. An assertion that would catch the inconsistent state in the internal data structures of the signal graph has been introduced. PR Close angular#51722
pkozlowski-opensource
added
action: review
JoostK
reviewed
Sep 14, 2023
Member
There was a problem hiding this comment.
This can be removed from this change I believe (it was the reason for the conflict)
Member
Author
There was a problem hiding this comment.
Oh, you are right. I'm assuming that main / 16.2 discrepancy comes from the effects scheduling change?
Member
There was a problem hiding this comment.
Yep, I think that's where the things diverged.
…ngular#51722) This commit adds explicit type annotations to the reactive node prototype objects, such that the prototypes are type-checked against the interface they are supposed to (partially) implement. This also allows IDEs to better track usages of reactive node properties, improving code navigation. PR Close angular#51722
pkozlowski-opensource
force-pushed
the
51722_16_2_patch
branch
from
072d9ea to
62d75de
Compare
crisbeto
approved these changes
Sep 14, 2023
pkozlowski-opensource
added
action: merge
Member
Author
|
This PR was merged into the repository by commit 7b40d74. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 14, 2023
…51772) When a producer is no longer used, the consumer has to update its internal data structure that keeps track of all producers. There used to be an issue where only half of the stale producers would actually be removed from this data structure, as the intended upper bound of the number of producers to remove would decrease with each removed producer, therefore not reaching all producers that should be removed from the data structure. This commit fixes the issue by truncating the arrays directly, without going through individual `pop` operations. An assertion that would catch the inconsistent state in the internal data structures of the signal graph has been introduced. PR Close #51722 PR Close #51772
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 14, 2023
…51722) (#51772) This commit adds explicit type annotations to the reactive node prototype objects, such that the prototypes are type-checked against the interface they are supposed to (partially) implement. This also allows IDEs to better track usages of reactive node properties, improving code navigation. PR Close #51722 PR Close #51772
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #51722 (comment)