Skip to content

fix(upgrade): assert correct interleaving of evaluation. - #4436

Closed
mhevery wants to merge 2 commits into
angular:masterfrom
mhevery:upgrade
Closed

mhevery wants to merge 2 commits into
angular:masterfrom
mhevery:upgrade

Conversation

@mhevery

@mhevery mhevery commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@mhevery
mhevery force-pushed the upgrade branch 2 times, most recently from 6fbd2c1 to 043a768 Compare September 30, 2015 22:53

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inject Log service instead. See test_lib/utils.ts

@vsavkin vsavkin added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 1, 2015
@vsavkin vsavkin assigned mhevery and unassigned vsavkin Oct 1, 2015
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 1, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #4436 on behalf of @mhevery to branch presubmit-mhevery-pr-4436.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 1, 2015
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Oct 1, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #4436 on behalf of @mhevery to branch presubmit-mhevery-pr-4436.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 1, 2015
@mhevery mhevery closed this in a562230 Oct 1, 2015
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants