WIP to test ubuntu support - #19
Conversation
| TP7lAoGAY/IHN42AVG1wjrvmLjs3W2DyvYEr3odzLhfQhWQB89Yqpni59N9iceMn | ||
| DQhxeuXzXIuAnjmHMsWC0FUzBcu+9ZgHIIqZFhTsC0zo6PS9gbgs+jKEG3U0j5hq | ||
| pwR7fKFYqY4er3ZILQDzG01cmwndAoU5Fj/Z4e816b8vxtEPa5w= | ||
| -----END RSA PRIVATE KEY----- |
There was a problem hiding this comment.
What is this for? Does it need to be checked in to the repository?
There was a problem hiding this comment.
doesn't kitchen coins a dummy private/pub ssh key on each run.. this is a bad missed gitignore thing
There was a problem hiding this comment.
no bad missed .gitignore -> https://github.com/JJediny/ansible-hardening/blob/master/.gitignore#L1-L4
| E, [2017-08-01T15:34:05.159095 #1448] ERROR -- Kitchen: /home/john/.rvm/gems/ruby-2.4.0/gems/test-kitchen-1.16.0/lib/kitchen/command.rb:197:in `public_send' | ||
| E, [2017-08-01T15:34:05.159120 #1448] ERROR -- Kitchen: /home/john/.rvm/gems/ruby-2.4.0/gems/test-kitchen-1.16.0/lib/kitchen/command.rb:197:in `run_action_in_thread' | ||
| E, [2017-08-01T15:34:05.159144 #1448] ERROR -- Kitchen: /home/john/.rvm/gems/ruby-2.4.0/gems/test-kitchen-1.16.0/lib/kitchen/command.rb:169:in `block (2 levels) in run_action' | ||
| E, [2017-08-01T15:34:05.159169 #1448] ERROR -- Kitchen: ----End Backtrace----- |
There was a problem hiding this comment.
This and the other log files should be ignored from Git.
There was a problem hiding this comment.
no bad missed .gitignore -> https://github.com/JJediny/ansible-hardening/blob/master/.gitignore#L1-L4
| username: kitchen | ||
| ssh_key: "/home/john/ansible-https-proxy/.kitchen/docker_id_rsa" | ||
| image_id: 76fac104ae78 | ||
| container_id: 07a32b35818e885f895f1be28b497b66cccccafabc8e7f0b18f079280e126859 |
| @@ -0,0 +1,9 @@ | |||
| --- | |||
| username: kitchen | |||
| ssh_key: "/home/john/ansible-https-proxy/.kitchen/docker_id_rsa" | |||
There was a problem hiding this comment.
Is an SSH key needed at all if using the Docker backend?
| fail: | ||
| when: http_req.location != 'https://localhost/' | ||
|
|
||
| # TODO Check that nginx is listening on port 443. Not the responsibility of this role to check for a response from the proxied service. |
There was a problem hiding this comment.
This is still an outstanding TODO. Should we make an issue instead?
Yeeeeah, this is annoying problem. Ansible is looking for a role by that name in its "roles path", but since the repository is cloned (by default) into a folder named
While the Test Kitchen setup seems nice for testing across different operating systems, I worry that it
I have been doing (simple) integration/acceptance/smoke testing as tasks within roles, and have been really happy with that approach. This keeps all the testing in Ansible, and runs those tests in the context of applying the role, which
Not saying we shouldn't use Test Kitchen...just that there are tradeoffs. |
| docker: | ||
| - image: docker | ||
| test-centos-7: | ||
| working_directory: ~/ansible-https-proxy |
There was a problem hiding this comment.
Changing this back might fix the build error.
No description provided.