Repository navigation
API joint for pulsar backend: Get List of function, Get function info, Get function stats, Get function status - #25
Merged
Merged
Conversation
RobertIndie
requested changes
Jun 7, 2021
RobertIndie
left a comment
RobertIndie
left a comment
Contributor
There was a problem hiding this comment.
The incorrect format URL caused the failure to get the function status.
RobertIndie
requested changes
Jun 8, 2021
RobertIndie
left a comment
RobertIndie
left a comment
Contributor
There was a problem hiding this comment.
I think there are still some problems with this PR. I got a 404 error when I open the index page.
In #26, I have set up an API env for this PR. You could merge the main branch to this PR then you can get that env. Also, you need to pay attention to modify the base URL.
…, Get function stats, Get function status
RobertIndie
requested changes
Jun 13, 2021
RobertIndie
left a comment
RobertIndie
left a comment
Contributor
There was a problem hiding this comment.
👍 Overall looks good to me!
We also need to push the changes of the .env.api here.
Contributor
|
Getting close! 👍 Please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #8