Skip to content

Support multi-input-topics config - #16

Merged
RobertIndie merged 31 commits into
FunctionStream:mainfrom
GiorunoGiovanna:main
Jun 13, 2021
Merged

RobertIndie merged 31 commits into
FunctionStream:mainfrom
GiorunoGiovanna:main

Conversation

@GiorunoGiovanna

@GiorunoGiovanna GiorunoGiovanna commented Jun 4, 2021 •

Copy link
Copy Markdown
Contributor

Master Issue FunctionStream/internal-discussion#12

input

@RobertIndie

RobertIndie commented Jun 6, 2021 •

Copy link
Copy Markdown
Contributor

@GiorunoGiovanna Please resolve conflicts.

@RobertIndie RobertIndie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the multi-input-topics configuration, I think we could adapt the implementation from #11.

@RobertIndie RobertIndie added the enhancement New feature or request label Jun 6, 2021
@RobertIndie RobertIndie added this to the 0.1.0 milestone Jun 6, 2021
@RobertIndie

Copy link
Copy Markdown
Contributor

@GiorunoGiovanna Please fix conflicts

@RobertIndie RobertIndie left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am stuck at the index page.
image
PTAL.

In addition, please do not add the changes related to other features in this PR. I saw that you added the images management feature, you need to create another PR to include that changes rather than here.

@RobertIndie RobertIndie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the comments.

Besides, when I click the reset button on the function creation page.
The input topic didn't reset completely :
image

Comment thread front-end/src/mock/services/func.js Outdated
},
fbeforeUpload () {
return false
// enterInput(e) { //输入input(支持逐个输入)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up comments.

Comment thread front-end/src/utils/request.js Outdated
timeout: 6000 // 请求超时时间
})

console.log(process.env.VUE_APP_API_BASE_URL)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log seems meaningless. We may need to delete this line.

Comment thread front-end/src/views/function/components/AddForm.vue Outdated
<a-button type="dashed" style="width: 100%" @click="addInput()">
<a-icon type="plus" /> Add inputs
</a-button>
<!-- <a-breadcrumb>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up comments

Comment thread front-end/src/views/function/components/AddForm.vue Outdated
Comment thread front-end/src/views/function/components/AddForm.vue Outdated
Comment thread front-end/src/config/router.config.js Outdated
component: () => import('@/views/function/index')
}

component: () => import('@/views/function/index'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem unnecessary and they include some eslint errors.

Comment thread front-end/src/views/function/components/AddForm.vue Outdated
Comment thread front-end/src/views/function/components/AddForm.vue Outdated
try {
await addFunc(values.functionName, values)
.then((res) => {
// console.log("success!")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up these comments

@RobertIndie RobertIndie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertIndie
RobertIndie merged commit 9417a06 into FunctionStream:main Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants