Repository navigation
Support multi-input-topics config - #16
Merged
Merged
Conversation
Contributor
|
@GiorunoGiovanna Please resolve conflicts. |
RobertIndie
requested changes
Jun 6, 2021
RobertIndie
left a comment
Contributor
There was a problem hiding this comment.
Regarding the multi-input-topics configuration, I think we could adapt the implementation from #11.
Contributor
|
@GiorunoGiovanna Please fix conflicts |
RobertIndie
requested changes
Jun 13, 2021
| }, | ||
| fbeforeUpload () { | ||
| return false | ||
| // enterInput(e) { //输入input(支持逐个输入) |
Contributor
There was a problem hiding this comment.
Please clean up comments.
| timeout: 6000 // 请求超时时间 | ||
| }) | ||
|
|
||
| console.log(process.env.VUE_APP_API_BASE_URL) |
Contributor
There was a problem hiding this comment.
This log seems meaningless. We may need to delete this line.
| <a-button type="dashed" style="width: 100%" @click="addInput()"> | ||
| <a-icon type="plus" /> Add inputs | ||
| </a-button> | ||
| <!-- <a-breadcrumb> |
Contributor
There was a problem hiding this comment.
Please clean up comments
| component: () => import('@/views/function/index') | ||
| } | ||
|
|
||
| component: () => import('@/views/function/index'), |
Contributor
There was a problem hiding this comment.
These changes seem unnecessary and they include some eslint errors.
Co-authored-by: Zike Yang <[email protected]>
Co-authored-by: Zike Yang <[email protected]>
Co-authored-by: Zike Yang <[email protected]>
Co-authored-by: Zike Yang <[email protected]>
RobertIndie
requested changes
Jun 13, 2021
| try { | ||
| await addFunc(values.functionName, values) | ||
| .then((res) => { | ||
| // console.log("success!") |
Contributor
There was a problem hiding this comment.
Please clean up these comments
Co-authored-by: Zike Yang <[email protected]>
Co-authored-by: Zike Yang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Master Issue FunctionStream/internal-discussion#12